[ https://issues.apache.org/struts/browse/STR-3191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=46524#action_46524 ]

Paul Benedict commented on STR-3191:
------------------------------------

Wes, I had the same thoughts but S1 has some interesting architectural issues that made me decide against it. It is a singleton, but there is also a setInstance() method so someone can provide their own implementation. If I stored the instance away as a static variable, I would never get the new instance set by application code. It's convoluted but it's supposed to work this way. Otherwise, I agree with you.

> Sufficently filter HTML tag attribute names and values
> ------------------------------------------------------
>
>                 Key: STR-3191
>                 URL: https://issues.apache.org/struts/browse/STR-3191
>             Project: Struts 1
>          Issue Type: Bug
>          Components: Tag Libraries
>    Affects Versions: 1.2.9, 1.3.10
>            Reporter: Paul Benedict
>            Assignee: Paul Benedict
>            Priority: Blocker
>             Fix For: 1.3.11, 1.4.0
>
>         Attachments: STR-3191-patch.txt
>
>
> Allows remote attackers to inject arbitrary web script or HTML via unspecified vectors related to insufficient quoting of parameters.
> * https://bugzilla.redhat.com/show_bug.cgi?id=CVE-2008-2025
> * http://support.novell.com/security/cve/CVE-2008-2025.html

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.