opensubscriber
   Find in this group all groups
 
Unknown more information…

f : freebsd-net@freebsd.org 18 May 2012 • 10:27PM -0400

Re: kern/110284: [if_ethersubr] Invalid Assumption in SIOCSIFADDR in ether_ioctl()
by John Baldwin

REPLY TO AUTHOR
 
REPLY TO GROUP




On Wednesday, May 16, 2012 10:37:36 pm Devon H. O'Dell wrote:
> 2012/5/16 Devon H. O'Dell <devon.odell@gmai...>:
> > Hi Gavin, freebsd-net,
> >
> > --- if_ethersubr.c      2011-09-22 20:51:37.000000000 -0400
> > +++ /home/dho/if_ethersubr.c    2012-05-16 22:27:17.000000000 -0400
> > @@ -1146,7 +1146,9 @@
> >                switch (ifa->ifa_addr->sa_family) {
> >  #ifdef INET
> >                case AF_INET:
> > -                       ifp->if_init(ifp->if_softc);    /* before
arpwhohas */
> > +                       if (ifp->if_flags & IFF_RUNNING == 0) {
>
> That's probably ((ifp->if_flags & IFF_RUNNING) == 0). Also, I'm not on
> freebsd-net or cc'ed on the PR afaik, so please cc me explicitly on
> followups if more information is needed.

You mean if_drv_flags and IF_DRV_RUNNING.

It's a bit fugly, yes, and the new check would be racey.

--
John Baldwin
_______________________________________________
freebsd-net@free... mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-net
To unsubscribe, send any mail to "freebsd-net-unsubscribe@free..."

Bookmark with:

Delicious   Digg   reddit   Facebook   StumbleUpon

Related Messages

opensubscriber is not affiliated with the authors of this message nor responsible for its content.