opensubscriber
   Find in this group all groups
 
Unknown more information…

d : dev@tapestry.apache.org 17 July 2009 • 7:45PM -0400

TAP5-769 and interface changes
by Ben Gidley

REPLY TO AUTHOR
 
REPLY TO GROUP




I have posted a patch for https://issues.apache.org/jira/browse/TAP5-769 that
resolves the issue. It allows javascript to be grouped into combined files
thus allowing you to share common javascript between pages.
An obvious enhancement would be to expose this to RenderSupport (at the
moment I have only made 'internal' changes) - however I was unsure of how
the interface should be changed. Following the thread recently -
RenderSupport is mostly an interface you would expect people to use not
implement, but it is not impossible someone has implemented it or wrapped
it.

So presuming a RenderSupport.addGroupedScriptLink(String group, String...
scriptURLs) was desirable should I create a RenderSupport2 or just add it to
RenderSupport?

As an aside what is the preferred way of telling commiters about patches -
do you want an email to this list as well as adding it to JIRA?

Ben Gidley

www.gidley.co.uk
ben@gidl...

Bookmark with:

Delicious   Digg   reddit   Facebook   StumbleUpon

Related Messages

opensubscriber is not affiliated with the authors of this message nor responsible for its content.