opensubscriber
   Find in this group all groups
 
Unknown more information…

c : courier-users@lists.sourceforge.net 8 June 2012 • 7:06AM -0400

Re: [courier-users] [PATCH] courier should use DESTDIR on test ! -w commands
by Sam Varshavchik

REPLY TO AUTHOR
 
REPLY TO GROUP




Hanno Böck writes:

> So the correct way should be another test for root, e.g.
> test `id -u` != 0
>
> I've prepared a patch.
> This is for both Makefile.in and Makefile.am to avoid the need for
> autotools, however the first one gets generated automatically, only the
> second one probably needs to be applied to courier.
> Please note however that this fixes the issue ONLY for module.esmtp,  
> although it seems to be
> prevalent all over the couriere Makefile.am files. I wanted first to
> discuss if this is the correct approach to fix it. If you're okay with
> that, I'll send you further patches for the others.

Although the intent seems to be ok, the patch itself does not really work.

Also, if you're preparing an automated package build, this isn't really  
needed. Running 'make install-perms' from the top level directory produces a  
very nicely-formatted file, permissions.dat, that lists all the files that  
get installed, and what their permissions should be. You should use that to  
prepare your package.


Bookmark with:

Delicious   Digg   reddit   Facebook   StumbleUpon

Related Messages

opensubscriber is not affiliated with the authors of this message nor responsible for its content.